Java: Add java/javautilconcurrentscheduledthreadpoolexecutor query for zero thread pool size#19844
Merged
tamasvajk merged 3 commits intogithub:mainfrom Jun 26, 2025
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
java/ql/src/Likely Bugs/Concurrency/ScheduledThreadPoolExecutorZeroThread.ql
Fixed
Show fixed
Hide fixed
...uery-tests/ScheduledThreadPoolExecutorZeroThread/ScheduledThreadPoolExecutorZeroThread.qlref
Fixed
Show fixed
Hide fixed
tamasvajk
force-pushed
the
tamasvajk/threadpoolexecutor
branch
from
e2b0faa to
c6a4221
Compare
…for zero thread pool size
tamasvajk
force-pushed
the
tamasvajk/threadpoolexecutor
branch
from
c6a4221 to
60e726b
Compare
java/ql/src/Likely Bugs/Concurrency/ScheduledThreadPoolExecutorZeroThread.ql
Show resolved
Hide resolved
owen-mc
reviewed
Jun 25, 2025
java/ql/src/Likely Bugs/Concurrency/ScheduledThreadPoolExecutorZeroThread.ql
Outdated
Show resolved
Hide resolved
michaelnebel
previously approved these changes
Jun 25, 2025
java/ql/src/Likely Bugs/Concurrency/ScheduledThreadPoolExecutorZeroThread.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Nebel <[email protected]>
owen-mc
approved these changes
Jun 26, 2025
tamasvajk
added
the
ready-for-doc-review
Contributor
Author
|
@subatoi Could you check the docs of this query too? I merged it without a docs-review, and looks like adding the tag after merging doesn't put it on your todo list. |
Contributor
|
@tamasvajk No worries. It looks fine. Just some trivial feedback but:
Might be better as (one-word change):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new query to identify potential issues with setting the
corePoolSizeofScheduledThreadPoolExecutorto zero, which may lead to unintended behavior and programmer error. The changes include adding the query logic, documentation, test cases, and integration into the query suite.MRVA top 100 only reports 4 alerts. I checked autofix on 3 of these. Two autofix suggestions completely removed the
executor.setCorePoolSize(0)calls, the third one changed the 0 value toSchedulers.DEFAULT_POOL_SIZE, which is the value used insetMaximumPoolSize.